Function is not working, but gives no error

Question

I'm new to C#. I'm trying to make game in Unity. These functions are necessary for changing in-game tabs with help of a button.

public string check;
public CanvasGroup hydrogenScreen;
public CanvasGroup heliumScreen;
private void EfficientTabChange(CanvasGroup group)
{
    string[] groupName = new string[2] { "hydrogenScreen" , "heliumScreen"};
    check = group.ToString();
    
    foreach (string nos in groupName)
    {
        
        if (check.Equals(nos))
        {
            ActivateTabs(group);
        }
        else
        {
            DeactivateTabs(group);
        }

    }
}
public void SwitchTabs(int id)
{
    switch (id)
    {
        case 0:
            EfficientTabChange(hydrogenScreen);
            break;
        case 1:
            EfficientTabChange(heliumScreen);
    }
}
private void ActivateTabs(CanvasGroup group)
{
    group.alpha = 1;
    group.interactable = true;
    group.blocksRaycasts = true;
}

private void DeactivateTabs(CanvasGroup group)
{
    group.alpha = 0;
    group.interactable = false;
    group.blocksRaycasts = false;
}

I don't know what is the problem in here. I'm just checking if the CanvasGroup is one of the names in array to find the right tab to change.

Are you able to step through the code using a debugger? Based on the logic it seems possible that the code is working exactly as designed and you're calling both ActivateTabs and DeactivateTabs every time, which would result in no visual change. Can you confirm? — David
– David, Commented Jan 27 at 19:34
ActivateTabs(group); and DeactivateTabs(group); use the same group (the parameter to the function). You want to call ActivateTabs on one group and DeactivateTabs on the other. — 001
– 001, Commented Jan 27 at 19:49
@001 note that string.Equals gives you a bit more control with additional parameters though where == just uses the most common — derHugo
– derHugo, Commented Jan 27 at 20:26

001 · Accepted Answer · 2025-01-27 20:06:34Z

3

The main issue is you pass the same group to ActivateTabs(group); and DeactivateTabs(group); So, instead of using strings, compare the groups directly.

private void EfficientTabChange(CanvasGroup group)
{
    CanvasGroup [] groups = new CanvasGroup[2] { hydrogenScreen, heliumScreen };
    
    foreach (CanvasGroup g in groups)
    {
        if (g == group)
        {
            ActivateTabs(g);
        }
        else
        {
            DeactivateTabs(g);
        }
    }
}

Collectives™ on Stack Overflow

Function is not working, but gives no error

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related