VBScript not setting variable inside If block [closed]

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.

This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.

Closed 5 months ago.

Improve this question

I'm working on a basic login check in VBS on Windows, just running from a .vbs file. I’ve been trying to set a loginSuccess flag based on a username check. It prints the welcome message correctly when the name matches, but the variable loginSuccess always ends up False outside the If. I can’t tell if it’s a scoping thing or what.

Dim username
username = InputBox("Enter your name:")

If username = "admin" Then
    Dim loginSuccess
    loginSuccess = True
    MsgBox "Welcome, admin!"
Else
    loginSuccess = False
    MsgBox "Access Denied"
End If

If loginSuccess Then
    MsgBox "You're logged in"
Else
    MsgBox "Login failed"
End If

No error shows up but the last message always says "Login failed" even when I type "admin". That first MsgBox in the If block works fine so I know the condition hits.

Your code works for me. You may consider to dimension loginSuccess outside the if clause. — Shrotter
– Shrotter, Commented Jul 9 at 17:25

Altxxr0 · Accepted Answer · 2025-07-09 18:28:16Z

-4

It’s because you're redeclaring loginSuccess inside the If, so VBScript treats it like a new local variable there, exactly like what @Shrotter said

You could try moving the Dim loginSuccess outside the If block

It should look something like this:

Dim username
Dim loginSuccess

username = InputBox("Enter your name:")

If username = "admin" Then
    loginSuccess = True
    MsgBox "Welcome, admin!"
Else
    loginSuccess = False
    MsgBox "Access Denied"
End If

If loginSuccess Then
    MsgBox "You're logged in"
Else
    MsgBox "Login failed"
End If

answered Jul 9 at 18:28

Altxxr0

2921 silver badge11 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

GSerg Jul 10 at 16:02

No, VBScript and VBA do not have the concept of block scoped variables, unlike VB.NET. Whatever the reason was for that code to not work, it wasn't that (and the code worked to begin with like Shrotter noted). The suggestion to move the variable declaration to the top makes the intent more clear, but does not change how this code runs.

Collectives™ on Stack Overflow

VBScript not setting variable inside If block [closed]

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related