Using Javascript to dynamically display a number

Question

This code should generate a page that displays a random number. Why doesn't it work?

<html>
    <head>
        <script type="text/javascript">
            window.onload = generateRandomNumber();
function generateRandomNumber()
{
    var n = 25;
    var number = Math.floor(Math.random()*n)+1;
    document.getElementById("randomNumber").value = number;
}
</script>
    </head>
    <body>
        <h1>
            Random number generated = <h1 id="randomNumber"></h1>
        </h1>
    </body>
</html>

check my answer.. updated as per your updated question.

dku.rajkumar
– dku.rajkumar

2012-01-11 10:49:52 +00:00
Commented Jan 11, 2012 at 10:49 — dku.rajkumar
– dku.rajkumar, Commented Jan 11, 2012 at 10:49
uploaded snapshot for your reference.. check it out

dku.rajkumar
– dku.rajkumar

2012-01-11 11:37:30 +00:00
Commented Jan 11, 2012 at 11:37 — dku.rajkumar
– dku.rajkumar, Commented Jan 11, 2012 at 11:37

dku.rajkumar · Accepted Answer · 2012-01-11 11:30:55Z

8

Make use of window.onload. try this

<head>
     <script type="text/javascript">
        window.onload = function(){
             var n = 25;
             var number = Math.floor(Math.random()*n)+1;
             document.getElementById("randomNumber").innerHTML = number;
        };
     </script>
 </head>

fiddle : http://jsfiddle.net/yyAf8/

EDIT as per updated question:

<head>
   <script type="text/javascript">
     window.onload = generateRandomNumber;
     function generateRandomNumber(){
         var n = 25;
         var number = Math.floor(Math.random()*n)+1;
         document.getElementById("randomNumber").innerHTML = number;
        }
  </script>
</head>

fiddle : http://jsfiddle.net/yyAf8/1/

uploading snapshot on demand by OP:

enter image description here

edited Jan 11, 2012 at 11:30

answered Jan 11, 2012 at 9:20

dku.rajkumar

18.6k8 gold badges43 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

node ninja Over a year ago

It doesn't work when the code is put in an html file. Can you show what the whole code looks like?

dku.rajkumar Over a year ago

uploaded snapshot in the answer.

node ninja Over a year ago

It wasn't working because I was setting value and not innerHTML.

Sergio Tulentsev · Accepted Answer · 2012-01-11 09:15:35Z

3

Because in your script you use an element that is not defined yet. Put the script after the element.

Demo: http://jsbin.com/upihez/2

answered Jan 11, 2012 at 9:15

Sergio Tulentsev

231k43 gold badges381 silver badges373 bronze badges

4 Comments

node ninja Over a year ago

OK that worked, but is there a way I can still keep the javascript code in in the head? Can I use onload to do this?

node ninja Over a year ago

I put it in a function and updated the code in my question. Why doesn't it work?

Sergio Tulentsev Over a year ago

Because this time generateRandomNumber doesn't exist! Do this: window.onload = function() {...}

node ninja Over a year ago

That didn't work. Can you show what my code looks like when it's fixed?

Collectives™ on Stack Overflow

Using Javascript to dynamically display a number

2 Answers 2

3 Comments

4 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

4 Comments

Related