validate JSON values [closed]

Well without any context I am going to go out on a limb and take a stab at this anyway.

First is if you are using a database, and have the ability to check for toy ID's instead of the toy names you won't have as many checks. it would require a little more work to pass in the string, but it would be very hard to change in the future if you get new toy names. IDs are a way of future proofing.

One trick of refactoring is to look at code that does the same thing and pulling it out into its own method. This is how I see your code working out.

public JsonResult ValidateAll(string toys)
{
    Dictionary<string, object> res = new Dictionary<string, object>();
    List<string> result_check = new List<string>();

    string[] lines = toys.Split(new string[] { "\n" }, StringSplitOptions.RemoveEmptyEntries);

    foreach (string line in lines)
    {
        var doll = CheckForToy(db.tblDoll, line);
        if(AddResult(doll, "doll", ref result_check))
            continue;

        if (table == "")
        {
            var car = CheckForToy(db.tblCar, line);
            if (AddResult(car, "car", ref result_check))
                continue;
        }
        var plane = CheckForToy(db.tblPlane, line)
        if(AddResult(plane, "plane, ref result_check))
            continue;

        var boat = CheckForToy(db.tblBoat, line)
        if(AddResult(boat, "boat, ref result_check))
            continue;
         //Do the same as for Car and Doll, do it for Plane and Boat too
    }
    res.Add("ok", result_check);
    return Json(res, JsonRequestBehavior.AllowGet);
}
private string CheckForToy(Table table, string line)
{
     string toyName = line;

     string toy_tmp = toyName.Trim();
     string toy_tmp2 = HttpUtility.HtmlEncode(HttpUtility.HtmlDecode(toyName)).Replace("&#228;", "&auml;").Trim();
     string toy_tmp3 = toyName.Replace("\u00a0", " ").Trim();
     string toy_tmp4 = HttpUtility.HtmlDecode(toyName.Trim());
     string toy_tmp5 = HttpUtility.HtmlDecode(toyName.Replace("\u00a0", " ").Replace(" ", " ").Trim());

     string tableInDatabase = "";

     //Check if the toy is a doll
     tblDoll toy = (from x in table
                              where (x.doll_name == toy_tmp || x.doll_name == toy_tmp2 || x.doll_name == toy_tmp3 || x.doll_name == toy_tmp4 || x.doll_name == itoy_tmp5)// || x.doll_name == toy_tmp6)
                        select x)
                        .FirstOrDefault();
    return toy;
}
private bool AddResult(Toy toy, string toyType, ref List<String> result)
{
    if(toy != null)
    {
        table = toyType;
        result.Add("1");
        return true;
    }
    return false;
}

There is probably even more ways to refactor my code, but without better context that is the best I can do. This is where having unit tests is super useful because you can continue to run your test every time you make a change to it to clean it up.

Your code is dealing with two kinds of toys. Every kind of toy is stored in its own table. This is not scalable. Every new toy kind (e.g. action figures, electronic toys, board games, toy music instruments, etc.) will require a new table and lots of new code.

You should refactor the whole approach.

I suggest two tables, each one of them backed by a corresponding element class:

1. A toy kind table
2. A toy table

public class Toy
{
    public int ToyId { get; set; }
    public string Name { get; set; }

    public int ToyKindId { get; set; }
    public ToyKind ToyKind { get; set; }
}

public class ToyKind
{
    public int ToyKindId { get; set; }
    public string Name { get; set; }

    public List<Toy> Toys { get; set; }
}

Now, querying the toy kind becomes very easy (starting from ToyKind):

string[] names = [toy_tmp, toy_tmp2, toy_tmp3, toy_tmp4];
string kind = db.ToyKinds
    .Include(kind => kind.Toys)
    .Where(kind => kind.Toys.Any(toy => names.Contains(toy.Name))
    .Select(kind => kind.Name)
    .FirstOrDefault();

Or (starting from Toy):

string[] names = [toy_tmp, toy_tmp2, toy_tmp3, toy_tmp4];
string kind = db.Toys
    .Include(toy => toy.ToyKind)
    .Where(toy => names.Contains(toy.Name))
    .Select(toy => toy.ToyKind.Name)
    .FirstOrDefault();