Re: Re: [RFC] Slim POST data (was: PHP-5.6 and $HTTP_RAW_POST_DATA)

From: Date: Mon, 02 Dec 2013 12:05:24 +0000
Subject: Re: Re: [RFC] Slim POST data (was: PHP-5.6 and $HTTP_RAW_POST_DATA)
References: 1 2 3 4 5 6 7 8 9 10 11  Groups: php.internals 
Request: Send a blank email to internals+get-70465@lists.php.net to get a copy of this message
On Mon, Dec 2, 2013 at 8:31 AM, Mike <mike.php.net@gmail.com> wrote:

> On Thu, 2013-11-28 at 10:00 +0100, Ferenc Kovacs wrote:
>
> >
> > Hi Mike,
> >
> > I think it would be nice to either reconstruct or split the RFC.
> > Currently it is a bit hard to tell, that what is changed in which
> > version.
>
> I changed to RFC to be easier comprehensible (hopefully).
>

thanks!


>
> > I think it would make sense, to have an RFC for 5.6 about introducing
> > the new stream, the new ini option and and how does it keeps userland
> > BC while providing a way to opt-in for the performance gain, and that
> > it introduces an E_DEPRECATED so we can remove the ini and the raw
> > post global variable in the next major version.
>
> I think we cannot add E_DEPRECATED to the INI-setting unless we make its
> default -1... which breaks BC :p
>
> Also, I think two RFCs would be quite much, but I already gave up my
> renitency.
>

we could emmit the error from populate_raw_post_data in
main/php_content_types.c, telling people that the auto population of
$HTTP_RAW_POST_DATA along with the use of always_populate_raw_post_data
will go away, and they should set always_populate_raw_post_data to -1 and
populate that variable for themself if their want to be forward compatible
(and silence the E_DEPRECATED messages).


-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu


Thread (32 messages)

« previous php.internals (#70465) next »