PHP mysql_fetch_array

Question

    $n=mysql_num_rows($rs);
    $i=0;    
    while($n>0)
        {
            while(($row=mysql_fetch_array($rs))&&$i<=5)
                {

                    echo $row['room_name'];
                    $i=$i+1;
                    //echo $n."<br>";
                }
                echo "<br>";
        //echo "n1=".$n;
        $n=$n-5;
        //
        $i=0;
        }

Output:101102103104105106
108109110

The row for roomname 107 is missing.... anybody please tell me what is the problem while reentering the loop again...

Is this some sort of obfuscated PHP code contest? (I really hope so) — Chad Birch
– Chad Birch, Commented Apr 7, 2010 at 5:05
I notice the output is missing the <br>... I find that disturbing — SeanJA
– SeanJA, Commented Apr 7, 2010 at 5:07
It has nothing to do with your English, this code is just extremely bad. It seems like you've jumped way ahead of your ability level, you're interacting with a database when you're missing fundamentals like for-loops. — Chad Birch
– Chad Birch, Commented Apr 7, 2010 at 5:13

codaddict · Accepted Answer · 2010-04-07 05:07:54Z

2

When $i becomes 6 you fetch a row but do nothing. Because fetching happens before the $i<=5 check, the fetched row gets skipped.

Change the order of conditions in the while loop.

while(($row=mysql_fetch_array($rs))&&$i<=5)

To

while($i<=5 && ($row=mysql_fetch_array($rs)))

answered Apr 7, 2010 at 5:07

codaddict

457k83 gold badges501 silver badges537 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chad Birch · Accepted Answer · 2010-04-07 05:23:38Z

2

Just to follow up on my comment, this whole chunk of code could have been written much more clearly as follows. (assuming you meant to put in a <br> after every 5 records, right now you're doing it after 6 but I think that's probably a mistake)

$rownum = 1;
while ($row = mysql_fetch_array($rs))
{
    echo $row['room_name'];

    if ($rownum % 5 == 0)
        echo '<br>';
    $rownum++;
}

answered Apr 7, 2010 at 5:23

Chad Birch

75k24 gold badges156 silver badges150 bronze badges

Comments

sam · Accepted Answer · 2010-04-07 05:12:47Z

0

here if are checking $i<=5 condition so array stats from 0 , so your database values stats from 101,102,..106, so it will 6 elements .

$i<=5 condition remove this condition in while keep the condition if($i%5==0) echo "
"; it will works

answered Apr 7, 2010 at 5:12

sam

3761 gold badge3 silver badges10 bronze badges

Collectives™ on Stack Overflow

PHP mysql_fetch_array

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related