mixing javascript and php variables in ajax

Question

I have a pretty basic jQuery ajax thing happening, but I want to mix form data that is retrieved by JS with some PHP variables and have them all sent as part of the ajax GET. Should this work?:

var longform = $("input:text").serialize(); 
$.ajax({
    url:    'actions/create.php',
    data:   longform + "domain=<?php echo $domain; ?>&useragent=<?php echo $useragent; ?>&ip=<?php echo $ip; ?>&cookieuser=<?php echo $cookieuser; ?>",

Currently, when create.php tries to echo the variables back, they're empty.

UPDATE

After checking the source as suggested, it comes out like this:

data:   longform + "&domain=example.com&useragent=Mozilla/5.0

possible duplicate: stackoverflow.com/questions/3658027/…

jwueller
– jwueller

2010-11-24 20:48:30 +00:00
Commented Nov 24, 2010 at 20:48 — jwueller
– jwueller, Commented Nov 24, 2010 at 20:48

simshaun · Accepted Answer · 2010-11-24 20:51:24Z

1

You need to add an ampersand (&) before domain=. Otherwise, it should be fine.

Do a View Source on the page and make sure the javascript string looks correct as well.

answered Nov 24, 2010 at 20:51

simshaun

21.5k1 gold badge60 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jwueller · Accepted Answer · 2010-11-24 20:55:40Z

1

Everything should be fine if you add PHP's urlencode()-function:

"domain=<?php echo urlencode($domain); ?>&useragent=<?php echo urlencode($useragent); ?>&ip=<?php echo urlencode($ip); ?>&cookieuser=<?php echo urlencode($cookieuser); ?>"

This should prevent syntax errors that could be caused by your data (i.e. if you have backslashes or other special chars in there).

answered Nov 24, 2010 at 20:55

jwueller

31.1k5 gold badges69 silver badges71 bronze badges

Comments

Tommaso Barbugli · Accepted Answer · 2010-11-24 21:02:34Z

0

I would rather put all data in hidden inputs, and then serialize all in once.

Tom

answered Nov 24, 2010 at 21:02

Tommaso Barbugli

12.1k2 gold badges46 silver badges42 bronze badges

1 Comment

Gary Over a year ago

Yes, I decided to go this route.. turns out my main problem was a dumb mistake on my part.. missed a $_GET in the php >_>

Collectives™ on Stack Overflow

mixing javascript and php variables in ajax

3 Answers 3

Comments

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Linked

Related