OOP php method - pass parameters in or get from inside object

Question

I am new to OOP and have written a products class. All is working fine but I am unsure which of the below version of a method within this class is best?

The first gets the variables from within the object and the second passes the variables into the class. Both work. I originally had it as the first version but things seems to be running slow and then changed it to the second.

public function getProductURLstart(){  
    $select = "SELECT l.URL, p.id FROM logins AS l
        INNER JOIN Pages AS p ON l.id = p.clientID 
        WHERE l.id = '$this->skID' AND p.productPage = 1";

    $res = mssql_query($select);
    $r = mssql_fetch_row($res);     

    $url = trim($r[0]); 
    $page_id = $r[1];

    return  $url .'/index.aspx?pageID='. $page_id . '&prodID=$this->prodID';
}

OR

static function getProductURLstart($skID, $prodId){    
    $select = "SELECT l.URL, p.id FROM logins AS l
        INNER JOIN Pages AS p ON l.id = p.clientID 
        WHERE l.id = '$skID' AND p.productPage = 1";

    $res = mssql_query($select);
    $r = mssql_fetch_row($res);     

    $url = trim($r[0]); 
    $page_id = $r[1];

    return  $url .'/index.aspx?pageID='. $page_id . '&prodID=$prodId';
}

palacsint · Accepted Answer · 2012-02-01 23:30:47Z

Which is the better should not depend on mainly speed. I think you should post more code (at least the name of class and its responsibilities or the list of its functions).

Some other notes:

It's really hard to read code which contains one character long variable names:
```
$r = mssql_fetch_row($res);
```
You have to decode them. I'd rename it to $row. The same true for the SQL queries: logins AS l. I would let it be logins.
In the second version there are three variable naming convention: $skID, $prodId, $page_id. Try to be consistent and use just one: they should be $skId, $prodId, $pageId or $skID, $prodID, $pageID or $sk_id, $prod_id, $page_id. (I think the first, the camelCase version is the most readable.)
There is no error handling in the code. What happens when the query returns empty results?
Probably the code is vulnerable to SQL injections: http://en.wikipedia.org/wiki/SQL_injection
Try accessing database attributes with keys not numeric indexes.
```
$url = trim($r[0]); 
$page_id = $r[1];
```
The following would be more readable:
```
$url = trim($r["url"]); 
$page_id = $r["id"];
```

wow, thanks for you advice, however I was looking for help with OOP and Im still none the wiser... — leanne
– leanne, Commented Nov 30, 2011 at 10:27
"I think you should post more code (at least the name of class and its responsibilities or the list of its functions)." :-) — palacsint
– palacsint, Commented Nov 30, 2011 at 11:02

Stack Exchange Network

OOP php method - pass parameters in or get from inside object

1 Answer 1

You must log in to answer this question.

Hot Network Questions

OOP php method - pass parameters in or get from inside object

1 Answer 1

You must log in to answer this question.

Related

Hot Network Questions