Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#16193moved the puretool_searchandtool_suggestspec builders intocodex-tools, butcodex-corestill owned the shared discoverable-tool model that those builders and thetool_suggestruntime both depend on. This change continues the migration by moving that reusable model boundary out ofcodex-coreas well, so the discovery/suggestion stack uses one shared set of types andcore/src/toolsno longer needs its owndiscoverable.rsmodule.What changed
DiscoverableTool,DiscoverablePluginInfo, andfilter_tool_suggest_discoverable_tools_for_client()intocodex-rs/tools/src/tool_discovery.rsalongside the extracted discovery/suggestion spec builders.codex-app-server-protocolas acodex-toolsdependency so the shared discoverable-tool model can own the connector-sideAppInfovariant directly.core/src/tools/handlers/tool_suggest.rs,core/src/tools/spec.rs,core/src/tools/router.rs,core/src/connectors.rs, andcore/src/codex.rsto consume the sharedcodex-toolsmodel instead of the old core-local declarations.core/src/plugins/discoverable.rsto returnDiscoverablePluginInfodirectly, moved the pure client-filter coverage intotool_discovery_tests.rs, and deleted the oldcore/src/tools/discoverable.rsmodule.codex-rs/tools/README.mdso the crate boundary documents thatcodex-toolsnow owns the discoverable-tool models in addition to the discovery/suggestion spec builders.Test plan
cargo test -p codex-toolsCARGO_TARGET_DIR=/tmp/codex-core-discoverable-model cargo test -p codex-core --lib tools::handlers::tool_suggest::CARGO_TARGET_DIR=/tmp/codex-core-discoverable-model cargo test -p codex-core --lib tools::spec::CARGO_TARGET_DIR=/tmp/codex-core-discoverable-model cargo test -p codex-core --lib plugins::discoverable::just bazel-lock-checkjust argument-comment-lintReferences