Comparing Elements Values In An Array, and returning Boolean

Question

Can anyone help I am nearly there I can get the code to return true for the first 2 test below, but not return false for the next 2 tests, what I need to do is to check that all the numbers in the array are in ascending order so every element number is greater than the last for the length of the array. Any ideas? Kind regards Jon.

 Test.expect(inAscOrder([1, 2, 4, 7, 19])
 Test.expect(inAscOrder([1, 2, 3, 4, 5])
 Test.expect(!inAscOrder([1, 6, 10, 18, 2, 4, 20])
 Test.expect(!inAscOrder([9, 8, 7, 6, 5, 4, 3, 2, 1])

function inAscOrder(arr) {

let result = false;

for (let i = 0; i <= arr.length; i++) {
for (let k = 0; k <= arr.length; k++) {
    if (arr[i] < arr[k+1]) {
     result = true;
            
    } 
   }
  }

return result; }

You were close, see this answer.

wraig
– wraig

2021-09-07 14:41:06 +00:00
Commented Sep 7, 2021 at 14:41 — wraig
– wraig, Commented Sep 7, 2021 at 14:41
you can use functional way to make life easier

Sachin Ananthakumar
– Sachin Ananthakumar

2021-09-07 14:46:28 +00:00
Commented Sep 7, 2021 at 14:46 — Sachin Ananthakumar
– Sachin Ananthakumar, Commented Sep 7, 2021 at 14:46

Armand · Accepted Answer · 2021-09-07 14:44:35Z

1

You were very close to answer

function inAscOrder(arr) {
    let result = true;

    for (let i = 0; i <= arr.length; i++) {
        if (arr[i] > arr[i+1]) {
            result = false;
            break;   
        }
    }
    return result; 
}

answered Sep 7, 2021 at 14:44

Armand

10.3k9 gold badges46 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jonathan Joseph Over a year ago

Thanks Armand I went down the single for loop route first of all and all I way missing was knowing how to compare the current iteration of the array i to the next element using i+1 in [ ]. Awesome thank you for your help much appreciated kind regards Jon.

Sachin Ananthakumar · Accepted Answer · 2021-09-07 14:52:49Z

1

Try this,

You can use the functional way instead.

const inAscOrder = arr => arr.slice(1).every((elem,i) => elem > arr[i]);
console.log(inAscOrder([1,2,5]));

edited Sep 7, 2021 at 14:52

answered Sep 7, 2021 at 14:42

Sachin Ananthakumar

8106 silver badges17 bronze badges

2 Comments

Mohit kumar Over a year ago

This is returning false for given input

Sachin Ananthakumar Over a year ago

@Mohitkumar editted the answer, now passes all testt

Invizi · Accepted Answer · 2021-09-07 14:46:53Z

0

The easiest way to compare two arrays, is to convert them to a strings and then compare the strings.

const isAscending = (arr) => arr.join("") == arr.sort((a, b) => a - b).join("");

console.log(isAscending([1, 2, 4, 7, 19]));
console.log(isAscending([1, 2, 3, 4, 5]));
console.log(isAscending([1, 6, 10, 18, 2, 4, 20]));
console.log(isAscending([9, 8, 7, 6, 5, 4, 3, 2, 1]));

answered Sep 7, 2021 at 14:46

Invizi

1,2881 gold badge8 silver badges7 bronze badges

Comments

James · Accepted Answer · 2021-09-07 14:55:20Z

0

For every element in the array, return true if it's the first element or it's greater than the previous element.

const isAscending = (arr) => arr.every((el, i, arr) => i === 0 || el > arr[i - 1]);

console.log(isAscending([1, 2, 4, 7, 19]));
console.log(isAscending([1, 2, 3, 4, 5]));
console.log(isAscending([1, 6, 10, 18, 2, 4, 20]));
console.log(!isAscending([9, 8, 7, 6, 5, 4, 3, 2, 1]));

answered Sep 7, 2021 at 14:55

James

22.4k5 gold badges29 silver badges44 bronze badges

Collectives™ on Stack Overflow

Comparing Elements Values In An Array, and returning Boolean

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Linked

Related