filtering with multiple conditions in javascript

Question

I am trying to filter data based on input and it works fine but I want add an extra condition to it. It should return if titel or another value (for example sendFrom) is given.

 const newData = masterDataSource.filter(function (item) {

    const itemData = item.titel  ? item.titel.toUpperCase() : ''.toUpperCase();
    const textData = text.toUpperCase();
    return itemData.indexOf(textData) > -1;
  });

I tried adding some operators but it didn´t worked out as planed

     const newData = masterDataSource.filter(function (item) {

    const itemData = item.titel || item.sendFrom ? item.titel.toUpperCase() || item.sendFrom.toUpperCase() : ''.toUpperCase();
    const textData = text.toUpperCase();
    return itemData.indexOf(textData) > -1;
  });

thanks

What exactly did not work out? And what is uppercase of ""? — Justinas
– Justinas, Commented Nov 12, 2021 at 11:51
''..toUpperCase() was unnecessary, sorry. I can still filter by titel but not by sendFrom — Brydawg
– Brydawg, Commented Nov 12, 2021 at 11:53

kikon · Accepted Answer · 2021-11-12 12:08:56Z

1

If I understand what you're after you would want something like:

const itemData = item.titel ? item.titel.toUpperCase() : (item.sendFrom ? item.sendFrom.toUpperCase() : ''.toUpperCase());

Parentheses are not required, but I added them to make it easier to get the logic.

Also, ''.toUpperCase() doesn't make much sense, it's the same as ''.

You could replace the initial condition with

const itemData = (item.titel  && item.titel.toUpperCase()) || '';

and the revised version:

const itemData = (item.titel  && item.titel.toUpperCase()) || (item.sendFrom  && item.sendFrom.toUpperCase()) || '';

Again, parentheses are not required.

References:
Conditional (ternary) operator
Logical Operators

answered Nov 12, 2021 at 12:08

kikon

9,9903 gold badges11 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Peter Seliger Over a year ago

(item.titel && item.titel.toUpperCase()) || (item.sendFrom && item.sendFrom.toUpperCase()) || ''; can be shortened to (item.titel || item.sendFrom)?.toUpperCase() ?? ''

kikon Over a year ago

I think it should be (item.titel || item.sendFrom || '').toUpperCase() since if there's neither .titel nor .sendForm you call undefined.toUpperCase() which results in an error.

Peter Seliger Over a year ago

nope ... notice the usage of both operators, the Optional chaining ( ?. ) and the Nullish coalescing operator ( ?? ). One wants to exit es early as possible and does not want to have as a fallback variant an additional avoidable ''.toUpperCase()

kikon Over a year ago

Wow, you're perfectly right! I didn't even know that ?. existed and I'm using js for 15 years!

Nina Scholz · Accepted Answer · 2021-11-12 11:57:33Z

1

You could collect the wanted properties in an array and iterate them while checking the values.

const newData = masterDataSource.filter(({ titel = '', sendFrom = '' }) => 
    [titel, sendFrom].some(s => s.toUpperCase().includes(text.toUpperCase()))
);

answered Nov 12, 2021 at 11:57

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Collectives™ on Stack Overflow

filtering with multiple conditions in javascript

2 Answers 2

4 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Related