1
\$\begingroup\$

I try to block all websites in Hebrew because I want to give more time on websites in other languages.

Given that many webmasters don't add <meta name="language" content="Hebrew"> meta attribute to all webpages of their websites I can't use it to block websites which appear in a certain language.

According to one work the most common letter in Hebrew is Yod ('), parallel to the Arabic Ya (ي) and common in all Semitic languages, so what I try to do is to just block any webpage that has Yod in it:

const [...elements] = document.getElementsByTagName("*");
elements.forEach((element) => {
  if (element.textContent.includes("י")) {
      window.open("https://google.com/", "_self");
  }
});

In my tests the code works on Hebrew-appearing-websites and doesn't work on non-Hebrew-appearing-websites, but maybe there is something to improve?

\$\endgroup\$
4
  • \$\begingroup\$ I don't understand the downvotes. If you think there is anything to improve please comment or suggest an edit (which I will gladly examine ASAP). \$\endgroup\$ Commented Oct 25, 2021 at 16:02
  • 4
    \$\begingroup\$ What prompted you to write this and what does the rest of the program look like? \$\endgroup\$ Commented Oct 25, 2021 at 16:04
  • \$\begingroup\$ @Mast I don't understand the first clarification question ; that's all my code in this context, there is no other code. \$\endgroup\$ Commented Oct 25, 2021 at 23:03
  • \$\begingroup\$ @Mast I have edited; is that better? \$\endgroup\$ Commented Oct 25, 2021 at 23:20

1 Answer 1

Reset to default
1
\$\begingroup\$

Your script will only work correctly if it is placed after the Yod character. Consider adding an event listener for window.load to only call it when all the content is loaded:

addEventListener("load", () => {
    ...
});

There is no need to iterate through all the elements. You could have simply used document.documentElement.innerHTML. The only problem with this is that it will find the character in the script itself. To fix this we can use String.fromCharCode:

if (document.documentElement.innerHTML.indexOf(String.fromCharCode(1497)) >= 0)
    document.location = 'https://he.wikipedia.org/';
\$\endgroup\$
1
  • \$\begingroup\$ Using window.onload does not guarantee it will be call as it can easily be over written by other code/extensions, Always use addEventListener to add listeners to ensure that they are called. window is the default this, it use is redundant (ie you don't use for window.document) thus window.onload = function () { becomes addEventListener("load", () => { \$\endgroup\$ Commented Oct 26, 2021 at 23:31

You must log in to answer this question.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.