Jquery Javascript - Make inline js a function

Question

Ok so this i probably very easy but i can't seem to figure it out. I have a a function but i still have to call the function inline. I am wondering if there is a way to put it all in the function. Right now my function looks like this:

function ddItem(el) {
 $(el).closest(".ddSelectHeader").find("input").attr({
    value : $(el).text()
})
 }

Then i call this function inline like this:

<div class="ddContainer">
<div class="ddSelectHeader"><input name="" type="text" />
<div class="ddSubmenu">
  <a href="#" onclick="ddItem(this)">Item 1</a><br />
  <a href="#" onclick="ddItem(this)">item 2</a>
  </div>
</div>

Ok so i am trying to make a simple drop down but with divs instead of the traditional ul li. The way it is written above works fine but i was hoping there is a way to take the onlcick out so that any link that is click within the ddSubmenu will populate the input field. This way i don't have to call it inline or in the html.

Thanks for the help.

James Montagne · Accepted Answer · 2012-01-23 04:04:46Z

4

$(document).ready(function() {
    $(".ddSubmenu a").click(function(){
        var $this = $(this);

        $this.closest(".ddSelectHeader").find("input").val($this.text());
    });
})

edited Jan 23, 2012 at 4:04

answered Jan 23, 2012 at 3:12

James Montagne

78.9k14 gold badges115 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

xdazz · Accepted Answer · 2012-01-23 03:14:10Z

1

$(function(){
    $('.ddSubmenu > a').click(function(){
        var self = $(this);
        self.closest(".ddSelectHeader").find("input").val(self.text());
    });
});

answered Jan 23, 2012 at 3:14

xdazz

161k38 gold badges255 silver badges278 bronze badges

3 Comments

James Montagne Over a year ago

+1 for value, I fixed the structure but missed what he was actually setting.

ShankarSangoli Over a year ago

@JamesMontagne - You can still modify your answer and make it better.

James Montagne Over a year ago

@ShankarSangoli Will do. Always feel funny amending my answer based on someone elses prior to an answer being accepted.

mowwwalker · Accepted Answer · 2012-01-23 03:12:39Z

0

Via javascript, you can use element.onclick: https://developer.mozilla.org/en/DOM/element.onclick

or jQuery's .click(): http://api.jquery.com/click/

answered Jan 23, 2012 at 3:12

mowwwalker

17.5k30 gold badges109 silver badges166 bronze badges

Comments

Kevin Ennis · Accepted Answer · 2012-01-23 03:12:45Z

0

$('.ddSubmenu a').click(function(){
    ddItem(this);
});

answered Jan 23, 2012 at 3:12

Kevin Ennis

14.5k2 gold badges46 silver badges44 bronze badges

Collectives™ on Stack Overflow

Jquery Javascript - Make inline js a function

4 Answers 4

Comments

3 Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

3 Comments

Comments

Comments

Related