Segmentation Fault with Pointers in C++

Question

I am trying to build an object of a struct but am getting a segmentation fault while assigning the values. After I build the object it will be passed by pointer into a list. Here is my implementation:

struct clientInfo {
  int client, a, b;
};
List *info=new List();

void thread(int which) {
  clientInfo *cI;
  cI->client=which;
  cI->a=4;
  cI->b=5;
  info->Append(cI);
}

During the execution of 'cI->client=which' a segmentation fault is produced. This project is being writting on the nachos platform for anyone that is familiar, however the definition of List is much the same as any linked list in C++. For anyone not familiar with nachos, 'void thread' is my 'int main'.

Thanks in advance.

@cnicutar: It's an academic operating system. For more info: cs.washington.edu/homes/tom/nachos/README — LihO
– LihO, Commented Mar 27, 2012 at 7:49
You should read a C++ book. Too many pointers, too many new. This is an attempt to make Java code in C++ and will only be painful. See the recommended books: stackoverflow.com/questions/388242/… — Matthieu M.
– Matthieu M., Commented Mar 27, 2012 at 7:56

LihO · Accepted Answer · 2012-03-27 07:06:18Z

4

clientInfo *cI; declares a pointer to an object of type clientInfo. It does not construct this object. You have to construct it before trying to access its members: cI = new clientInfo();.

answered Mar 27, 2012 at 7:06

LihO

42.3k11 gold badges103 silver badges169 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

xanatos · Accepted Answer · 2012-03-27 07:05:36Z

3

You have to create the clientInfo *cI, like

clientInfo *cI = new clientInfo();

answered Mar 27, 2012 at 7:05

xanatos

112k13 gold badges209 silver badges296 bronze badges

1 Comment

cazzer Over a year ago

your infinite wisdom is only surpassed by my infinite stupidity. Thank you for your quick response.

Emilio Garavaglia · Accepted Answer · 2012-03-27 07:41:28Z

2

The cI pointer is actually pointing "nowhere meaningful to you" when ci->members are assigned. Initilize the pointer to something existent (or allocate something for it) before use it.

edited Mar 27, 2012 at 7:41

answered Mar 27, 2012 at 7:06

Emilio Garavaglia

20.9k3 gold badges50 silver badges66 bronze badges

1 Comment

bryce Over a year ago

FWIW, depending on how the program's compiled, the pointer might point to a random memory location or to NULL.

Vijay · Accepted Answer · 2012-03-28 08:58:19Z

1

You cannot directly assign values to a structure pointer.it should be given some allocation using new like :

 clientInfo *cI =new  clientInfo();

If you dont wish to do this just decalre the object rather than a pointer *cI. like below:

clientInfo cI;

Now you can directly assign values like cI.a=... and this data will be stroed on stack and not on heap.

answered Mar 28, 2012 at 8:58

Vijay

67.7k94 gold badges238 silver badges327 bronze badges

Collectives™ on Stack Overflow

Segmentation Fault with Pointers in C++

4 Answers 4

Comments

1 Comment

1 Comment

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

1 Comment

Comments

Linked

Related